Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Ri and Pr functions #131

Merged
merged 1 commit into from
Aug 17, 2021
Merged

add Ri and Pr functions #131

merged 1 commit into from
Aug 17, 2021

Conversation

yairchn
Copy link
Member

@yairchn yairchn commented Aug 16, 2021

This PR adds standalone gradient Richardson number and turbulent Prandtl number functions that are called from compute_mixing_length. It is the first step to organizing mixing length function.

WIP

move pr scale to paramset

WIP

WIP

debugging

fix bug
@yairchn yairchn force-pushed the yc/Turbulent_Prandtl_number branch from 5549be4 to aa82966 Compare August 17, 2021 01:30
Copy link
Member

@charleskawczynski charleskawczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're good to merge this 🚀

@yairchn
Copy link
Member Author

yairchn commented Aug 17, 2021

Bors r+

@bors
Copy link
Contributor

bors bot commented Aug 17, 2021

@bors bors bot merged commit 542ca4d into main Aug 17, 2021
@bors bors bot deleted the yc/Turbulent_Prandtl_number branch August 17, 2021 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants